Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle file deletion notification #1300

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Handle file deletion notification #1300

merged 1 commit into from
Oct 29, 2024

Conversation

soutaro
Copy link
Owner

@soutaro soutaro commented Oct 29, 2024

The DELETED notification is 3, not 4, and caused unexpected nil content sent to workers.

Closes #1236 #1237

@soutaro soutaro added this to the Steep 1.9 milestone Oct 29, 2024
@soutaro soutaro enabled auto-merge October 29, 2024 06:50
@soutaro soutaro merged commit 89a2ac4 into master Oct 29, 2024
18 checks passed
@soutaro soutaro deleted the delete-files branch October 29, 2024 06:54
soutaro added a commit that referenced this pull request Oct 29, 2024
Handle file deletion notification
soutaro added a commit that referenced this pull request Oct 29, 2024
@soutaro soutaro added the Released The PR is already included in a published release label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released The PR is already included in a published release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSP workers crash on file removal
1 participant